Permit long lines if a URL is present on it #34
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at #21 and noticed that most of us just want exceptions for when URLs cause really long lines. This covers that use case, which looks like it's good enough most of the time for now.
The current heuristic just looks for things like
http://
, because I think stuff like this is reasonable, but would be rejected if the heuristic was stricter:Another good heuristic may be
^[[:blank:];]*[[:graph:]]+$
, which while it would reject the above, would instead match any really long running single-"word". Generally only URLs, or at least things that cannot be broken up like filenames, match this heuristic. Pycodestyle uses this heuristic too. Happy to switch to that if that is preferred.