feat: support GitHub App authentication #1988
Open
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ullaakut
approved these changes
Oct 1, 2024
matt0x6F
requested changes
Oct 2, 2024
There was a problem hiding this comment.
So, this only works for github.com. The application is leveraging bradleyfalzon/ghinstallation which has a clear path for supporting both GHE and github.com. Can we PR, fork, or import in order to support both instead?
|
I am wondering if GHE support should be a second step for this? I would prefer to try upstream the GHE support first, before running a separate fork, and this can take time. Would gladly make an Issue to keep track and a note in the docs about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
This adds support for GitHub App authentication using Git Credential Helpers.
How is the fix applied?
The GHA Git Credential Helper is installed in the Docker image by default, and the process is documented.