Moved helm chart to new repo #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should I remove |
DrPsychick
force-pushed
the
move-helm-chart
branch
from
799b9bf
to
32429b4
Compare
|
Adjusted as discussed on slack @manugupt1 and only link to the temporary repo from the README. |
manugupt1
approved these changes
Feb 3, 2023
r-ashish
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
I'm thinking whether it would make more sense to keep the charts under https://github.com/gomods instead. We can create a github page for this, if required.
I'm approving anyway to unblock. We can consider moving it under gomods later if we don't find a long term solution soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Separate Helm chart and take over maintenance as well as make the chart downloadable again (fully public, on GitHub).
How is the fix applied?
Update all references to the chart in the repo and remove the chart.
What GitHub issue(s) does this PR fix or close?
Fixes #1795
Fixes #1803
Fixes #1638
Fixes #1651