copy context before starting stash operations to prevent ctx cancellations #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I came across another PR trying to fix the same issue: #1765 but I'm not seeing any activity on it so I decided to create a new PR since this has been bothering us as well. For now we've set the mode to I've tried to incorporate the suggestions from the comments on the other PR as well. Do let me know if I missed anything. |
r-ashish
changed the title
r-ashish
force-pushed
the
fix-ctx-deadline
branch
from
38605b6
to
fc9d266
Compare
marwan-at-work
approved these changes
Sep 15, 2022
|
here, The problem still exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
We started receiving some
RequestCanceled: request context cancelederrors after setting the download mode toasync_redirect(same problem happens withasyncas well).After some investigation we found that the same context from the HTTP handler is being passed to stasher and the async routines fail to continue after the request is complete since the context gets cancelled after completion.
This PR creates a new context with custom timeout and copies over some values from the old context to solve this issue.