Using directory as prefix for S3 #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the fix. I'm surprised this hasn't come up before.
I think we could really use some integration testing here but unfortunately I don't have an AWS account.
cc: @arschles
|
@marwan-at-work Can you take another look? |
|
@linzhp just a nit comment and looks good 👍🏼 |
marwan-at-work
approved these changes
Aug 19, 2021
linzhp
added a commit
to linzhp/athens
that referenced
this pull request
Aug 26, 2022
Summary: * change configuration to use S3 as the storage client * configure parameters to call Terrablob with S3 API according to https://engwiki.uberinternal.com/display/TERRABLOB/S3+HTTP+API * Patch the S3 client to put all modules under a path prefix that we use in Terrablob * Patch a pending pull request gomods#1720 Test Plan: * deployed to staging, change GOPROXY to point to staging, and run `go clean -modcache && go mod tidy` Reviewers: tanx, sergeyb Reviewed By: tanx, sergeyb JIRA Issues: GM-673 Differential Revision: https://code.uberinternal.com/D6235753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Listing objects on S3 with prefixes like
github.com/golang/mock/@v/v1.4.4.with return empty list, because prefixes are directories on S3 (https://docs.aws.amazon.com/AmazonS3/latest/userguide/using-prefixes.html).How is the fix applied?
Taking the directory name from the path returned by
config.PackageVersionedName(module, version, ""), so it can return all files for the module. Because of this, all files from all versions will be returned and filtered later.