Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sumdb/* paths when config.PathPrefix is set #1620

Merged
merged 6 commits into from
Jun 5, 2020
Merged

Fix sumdb/* paths when config.PathPrefix is set #1620

merged 6 commits into from
Jun 5, 2020

Commits on May 24, 2020

  1. Fix sumdb/* paths when config.PathPrefix is set 

    http.StripPrefix will look at the entire request path when called,
if we do not include config.PathPrefix then the StripPrefix call
will never receive a valid path from the application and the user
will always get a 404 error.

There were no test where I could easily check this regression so
I also added a few endpoint tests, the last test will fail with
a 404 instead of 403 if this change in not applied.
    @elliotmr
    elliotmr committed May 24, 2020
    Configuration menu
    Copy the full SHA
    9ad92e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Update cmd/proxy/actions/app_proxy.go 

    Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
    @elliotmr
    elliotmr and Marwan Sulaiman authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    d45c8ae View commit details
    Browse the repository at this point in the history

  2. Update cmd/proxy/actions/app_proxy_test.go 

    Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
    @elliotmr
    elliotmr and Marwan Sulaiman authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    20dbb9e View commit details
    Browse the repository at this point in the history

  3. Update cmd/proxy/actions/app_proxy_test.go 

    Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
    @elliotmr
    elliotmr and Marwan Sulaiman authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    2844f92 View commit details
    Browse the repository at this point in the history

  4. Update cmd/proxy/actions/app_proxy_test.go 

    Co-authored-by: Marwan Sulaiman <marwan-at-work@github.com>
    @elliotmr
    elliotmr and Marwan Sulaiman authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    b584a90 View commit details
    Browse the repository at this point in the history

  5. Removed unneeded import of logrus

    @elliotmr
    elliotmr authored Jun 5, 2020
    Configuration menu
    Copy the full SHA
    85f2af2 View commit details
    Browse the repository at this point in the history