Fix #1268: Launch tini as subreaper #1269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwan-at-work
requested changes
Jun 4, 2019
There was a problem hiding this comment.
Per #1268 (comment),
I wasn't able to reproduce the issue.
We should try to figure out what's the inconsistency first before merging.
However, if the "-s" flag has no side effects and is okay to include in all cases, maybe we should just include it. The only thing I found in the Tini README is that it required linux > 3.4
Thank you for the contribution ✌️
|
Closing as we decided to just add documentation instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
-sparameter to launchtinias subreaper by default.Fixes #1268