Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the TeamCity inspectionType service message #4573

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

namco1992
Copy link
Contributor

The Inspection Type is used in the TeamCity printer. The message type should be inspectionType as the doc specified, but the golangci-lint uses InspectionType(capitalized "I").

I'm not sure if it works with previous TeamCity versions, I'm currenly on "TeamCity Enterprise 2023.11.3 (build 147512)" and it doesn't work for me. Changing the InspectionType to inspectionType did the trick.

Update the TeamCity printer to have it align with the specification, and avoid any surprise in the future.

The [Inspection Type](https://www.jetbrains.com/help/teamcity/service-messages.html#Inspection+Type) is used in the TeamCity printer.
The message type should be `inspectionType` as the doc specified, but
the golangci-lint uses `InspectionType`(capitalized "I").

I'm not sure if it works with previous TeamCity versions, I'm currenly
on "TeamCity Enterprise 2023.11.3 (build 147512)" and it doesn't work
for me. Changing the `InspectionType` to `inspectionType` did the trick.

Update the TeamCity printer to have it align with the specification, and
avoid any surprise in the future.

Signed-off-by: Mengnan Gong <namco1992@gmail.com>
Copy link

boring-cyborg bot commented Mar 25, 2024

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2024

CLA assistant check
All committers have signed the CLA.

@ldez ldez added area: output Related to issue output bug Something isn't working labels Mar 25, 2024
@ldez ldez added this to the next milestone Mar 25, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 5ae78cd into golangci:master Mar 25, 2024
13 checks passed
@ldez ldez modified the milestones: next, v1.57 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: output Related to issue output bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants