feat: replace gomnd by mnd

[ldez]

Rename gomnd to mnd:

• Deprecate gomnd.
• Add mnd.

This PR also fixes the problem of consistency between the analyzer name and linter name like #4567.

Before

$ golangci-lint run 
main.go:28:23: mnd: Magic number: 200, in <condition> detected (gomnd)
        if res.StatusCode != 200 {
                             ^
main.go:21:12: mnd: Magic number: 2, in <assign> detected (gomnd)
                Timeout: 2 * time.Second,
                         ^

With the PR

$ golangci-lint run 
main.go:28:23: Magic number: 200, in <condition> detected (mnd)
        if res.StatusCode != 200 {
                             ^
main.go:21:12: Magic number: 2, in <assign> detected (mnd)
                Timeout: 2 * time.Second,
                         ^

[bombsimon]

LGTM, as long as the name actually is just mnd. I see it's set to mnd in the code but most of the references refer to it as go-mnd and so does the gopher image in the repo.

@tommy-muehle Can you confirm that the name of the linter should be just mnd or would you rather set the name to gomnd on the analyzer? I guess mnd makes more sense since it's the name of the binary as well but might as well ask to clarify.

[ldez]

I see it's set to mnd in the code but most of the references refer to it as go-mnd and so does the gopher image in the repo.

So you are saying that only my first commit (coming from the previous PR) was enough, it's because you need more PRs to review? 😸

[bombsimon]

So you are saying that only my first commit (coming from the previous PR) was enough, it's because you need more PRs to review? 😸

I'm sorry if this yielded extra work for you. I was mostly asking a question and didn't have the time to reply to your comments in the other PR before you created this one. I thought, and I think you did as well based on this PR, that the name is actually mnd and with that in mind I think this PR is the right thing to do. However I see no downside in asking the author about the name.

If the linter would be named gomnd I think an upstream PR would make more sense than the overwriting in the other PR anyway.

I approved this PR because maybe you have different context or feel different about this so feel free to merge. I did not try to get more PRs to review.

[ldez]

I'm sorry if this yielded extra work for you.

I was just kidding 😸

I was torn between the name change and the deprecation, so I used your comment as justification.

[ldez]

More seriously, the readme is a mix of go-mnd and mnd but the command, the binary, the analyzer, and the brew-tap are called mnd.
Only the Docker image and the repository are named go-mnd.

We will wait for the feedback of the author but mnd seems to be the right name.

[bombsimon]

We will wait for the feedback of the author but mnd seems to be the right name.

Yeah 100% agree! I pinged to see if we got some response within a day or two max but I wouldn't block too long on it.