Skip to content

Commit

Permalink
build(deps): bump github.com/kkHAIKE/contextcheck from 1.1.4 to 1.1.5 (
Browse files Browse the repository at this point in the history
…#4564)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
  • Loading branch information
dependabot[bot] and ldez committed Mar 23, 2024
1 parent b78225b commit afd670b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ require (
github.com/julz/importas v0.1.0
github.com/karamaru-alpha/copyloopvar v1.0.9
github.com/kisielk/errcheck v1.7.0
github.com/kkHAIKE/contextcheck v1.1.4
github.com/kkHAIKE/contextcheck v1.1.5
github.com/kulti/thelper v0.6.3
github.com/kunwardeep/paralleltest v1.0.10
github.com/kyoh86/exportloopref v0.1.11
Expand Down
4 changes: 2 additions & 2 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions pkg/result/processors/invalid_issue.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ func (p InvalidIssue) shouldPassIssue(issue *result.Issue) (bool, error) {
}

if issue.FilePath() == "" {
// contextcheck has a known bug https://github.com/kkHAIKE/contextcheck/issues/21
if issue.FromLinter != "contextcheck" {
p.log.Warnf("no file path for the issue: probably a bug inside the linter %q: %#v", issue.FromLinter, issue)
}
p.log.Warnf("no file path for the issue: probably a bug inside the linter %q: %#v", issue.FromLinter, issue)

return false, nil
}
Expand All @@ -47,6 +44,7 @@ func (p InvalidIssue) shouldPassIssue(issue *result.Issue) (bool, error) {

if !isGoFile(issue.FilePath()) {
p.log.Infof("issue related to file %s is skipped", issue.FilePath())

return false, nil
}

Expand Down

0 comments on commit afd670b

Please sign in to comment.