Skip to content

Commit

Permalink
build(dep): Ignore known dependency failure in nancy (#1378)
Browse files Browse the repository at this point in the history
Currently nancy is always failed, and we seem to ignore it completely.
This reduces the value of having security scanning significantly.
Ideally, the underlying issue should be fixed, however it will require
long time for external collaboration.

This commit is to ignore two known dependency failures.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
  • Loading branch information
sayboras committed Sep 21, 2020
1 parent 5f93c93 commit ad26b68
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pr-extra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
# We cannot use nancy-github-action because it is outdated, so it's better to use the latest
# docker image for the validation
- name: nancy
run: go list -json -m all | docker run -i sonatypecommunity/nancy:v0.3
- name: Run go list
run: go list -json -m all > go.list
- name: Nancy
uses: sonatype-nexus-community/nancy-github-action@master
11 changes: 11 additions & 0 deletions .nancy-ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Skip for golang/golang.org/x/net@v0.0.0-20200904194848-62affa334b73
CVE-2018-17848
CVE-2018-17143
CVE-2018-17847
CVE-2018-17142
CVE-2018-17846

# Skip for indirect dependency github.com/coreos/etcd@3.3.13
CVE-2020-15114
CVE-2020-15115
CVE-2020-15136

0 comments on commit ad26b68

Please sign in to comment.