Skip to content

Commit

Permalink
quic: report initial TLS errors
Browse files Browse the repository at this point in the history
Pass errors from QUICConn.Start and the initial flight of TLS events
up to the caller.

For golang/go#58547

Change-Id: I3a32986bc19a2dd9bf43cd08e3fdd1fa93251a0c
Reviewed-on: https://go-review.googlesource.com/c/net/+/529737
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
  • Loading branch information
neild committed Sep 20, 2023
1 parent 8add2e1 commit 732b4bc
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions internal/quic/conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func newConn(now time.Time, side connSide, initialConnID []byte, peerAddr netip.
c.lifetimeInit()

// TODO: initial_source_connection_id, retry_source_connection_id
c.startTLS(now, initialConnID, transportParameters{
if err := c.startTLS(now, initialConnID, transportParameters{
initialSrcConnID: c.connIDState.srcConnID(),
ackDelayExponent: ackDelayExponent,
maxUDPPayloadSize: maxUDPPayloadSize,
Expand All @@ -119,7 +119,9 @@ func newConn(now time.Time, side connSide, initialConnID []byte, peerAddr netip.
initialMaxStreamsBidi: c.streams.remoteLimit[bidiStream].max,
initialMaxStreamsUni: c.streams.remoteLimit[uniStream].max,
activeConnIDLimit: activeConnIDLimit,
})
}); err != nil {
return nil, err
}

go c.loop(now)
return c, nil
Expand Down

0 comments on commit 732b4bc

Please sign in to comment.