Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the system robot account and the project robot account sections #517

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Dec 8, 2023

  1. Fixes Update the doc for robot account harbor#19354

This is how the Permission References tables look like:
Screenshot 2023-12-08 at 13 47 42

@AllForNothing
Copy link
Contributor Author

@Vad1mo @OrlinVasilev Please help review the English text, thanks!!!

…tions

1. Fixes goharbor/harbor#19354

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
@stonezdj stonezdj dismissed Vad1mo’s stale review December 19, 2023 03:00

Vadim, because we have to GA Harbor 2.10.0, before raise another PR to update the current comments, I merge the current PR

@stonezdj stonezdj requested a review from Vad1mo December 19, 2023 03:06
@stonezdj
Copy link
Contributor

Hi, @Vad1mo @OrlinVasilev I 'll merge the current PR and raise another PR to fix issues mentioned in your comments.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 0a99537 into goharbor:main Dec 19, 2023
5 checks passed
stonezdj added a commit to stonezdj/website that referenced this pull request Dec 19, 2023
fixes issues mentioned in PR goharbor#517

Signed-off-by: stonezdj <stonezdj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the doc for robot account
6 participants