Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Portal french translation #18289

Merged

Conversation

thcdrt
Copy link
Contributor

@thcdrt thcdrt commented Feb 28, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Fix missing translations + typo on Portal French file.

Thomas

@thcdrt thcdrt requested a review from a team as a code owner February 28, 2023 17:03
@thcdrt thcdrt force-pushed the dev/thcdrt/improve-french-traduction branch 2 times, most recently from 4539928 to ba179b4 Compare February 28, 2023 22:43
@AllForNothing AllForNothing added release-note/community release-note/enhancement Label to mark PR to be added under release notes as enhancement labels Mar 1, 2023
@AllForNothing
Copy link
Contributor

AllForNothing commented Mar 1, 2023

@thcdrt Could you ask at least one other French speaker to review your PR?

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #18289 (da2c9d9) into main (fe236ec) will increase coverage by 22.92%.
The diff coverage is n/a.

❗ Current head da2c9d9 differs from pull request most recent head 6f9fd05. Consider uploading reports for the commit 6f9fd05 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18289       +/-   ##
===========================================
+ Coverage   44.54%   67.46%   +22.92%     
===========================================
  Files         233      971      +738     
  Lines       13022   106223    +93201     
  Branches     2660     2649       -11     
===========================================
+ Hits         5800    71667    +65867     
- Misses       6926    30720    +23794     
- Partials      296     3836     +3540     
Flag Coverage Δ
unittests 67.46% <ø> (+22.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 746 files with indirect coverage changes

Copy link

@Lucasgranet Lucasgranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little mistakes

src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
@thcdrt thcdrt force-pushed the dev/thcdrt/improve-french-traduction branch from ba179b4 to 5c4fe59 Compare March 1, 2023 10:34
@thcdrt thcdrt requested a review from Lucasgranet March 1, 2023 10:34
@AllForNothing AllForNothing force-pushed the dev/thcdrt/improve-french-traduction branch from 5c4fe59 to 51e513f Compare March 6, 2023 02:03
@MinerYang
Copy link
Contributor

could you help to rebase then we are good to merge

@thcdrt thcdrt force-pushed the dev/thcdrt/improve-french-traduction branch from 51e513f to 87932ed Compare March 6, 2023 09:20
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
Copy link

@rverchere rverchere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some review here!

Another comment: for "pull", sometimes you use "tirer", sometimes "récupérer".
It would be fin to use always the same verb (I prefer "récupérer"), or just let "pull"

src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
@thcdrt
Copy link
Contributor Author

thcdrt commented Mar 8, 2023

Some review here!

Another comment: for "pull", sometimes you use "tirer", sometimes "récupérer". It would be fin to use always the same verb (I prefer "récupérer"), or just let "pull"

Thank you for your review, indeed, as answered to Theo, I asked myself which one to chose but as I couldn't take a decision I let it as it was.
Shoudl we keep "push" and "pull" everywhere ?

@thcdrt thcdrt force-pushed the dev/thcdrt/improve-french-traduction branch 2 times, most recently from ee4ffc7 to 335cb31 Compare March 8, 2023 22:21
@TheGthr
Copy link

TheGthr commented Mar 9, 2023

Some review here!
Another comment: for "pull", sometimes you use "tirer", sometimes "récupérer". It would be fin to use always the same verb (I prefer "récupérer"), or just let "pull"

Thank you for your review, indeed, as answered to Theo, I asked myself which one to chose but as I couldn't take a decision I let it as it was. Shoudl we keep "push" and "pull" everywhere ?

Yes, I think keeping "push" and "pull" everywhere will make it more consistent, thank you

src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
@thcdrt
Copy link
Contributor Author

thcdrt commented Mar 9, 2023

Thank you all for your reviews, all suggestions have been applied

@thcdrt thcdrt force-pushed the dev/thcdrt/improve-french-traduction branch from 0be33e6 to ed3a0ce Compare March 9, 2023 20:50
@thcdrt thcdrt force-pushed the dev/thcdrt/improve-french-traduction branch from ed3a0ce to e82ef27 Compare March 10, 2023 10:58
@AllForNothing
Copy link
Contributor

@thcdrt Please ping me if this PR is good to merge,I can help to merge it

@thcdrt
Copy link
Contributor Author

thcdrt commented Mar 14, 2023

@thcdrt Please ping me if this PR is good to merge,I can help to merge it

Hello @AllForNothing, for me PR is good to merge :)

@AllForNothing AllForNothing force-pushed the dev/thcdrt/improve-french-traduction branch from da2c9d9 to cc5f410 Compare March 15, 2023 02:13
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
Signed-off-by: Thomas Coudert <thomas.coudert@ovhcloud.com>
@AllForNothing AllForNothing force-pushed the dev/thcdrt/improve-french-traduction branch from cc5f410 to 6f9fd05 Compare March 15, 2023 03:10
@AllForNothing AllForNothing merged commit 5287c0e into goharbor:main Mar 15, 2023
@thcdrt thcdrt deleted the dev/thcdrt/improve-french-traduction branch March 20, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/community release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants