Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Multiple Type of Database #16615

Closed
wants to merge 2 commits into from

Conversation

JinXingYoung
Copy link

Support MySQL and MariaDB
Related issue: #6534
Signed-off-by: yvonnexyang yvonnexyang@tencent.com

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #16615 (ff4eb7f) into feat/multi-db (1449988) will decrease coverage by 0.30%.
The diff coverage is 52.92%.

❗ Current head ff4eb7f differs from pull request most recent head 098974d. Consider uploading reports for the commit 098974d to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           feat/multi-db   #16615      +/-   ##
=================================================
- Coverage          67.35%   67.05%   -0.31%     
=================================================
  Files                953      979      +26     
  Lines              79016    82261    +3245     
  Branches            2331     2630     +299     
=================================================
+ Hits               53221    55159    +1938     
- Misses             22220    23316    +1096     
- Partials            3575     3786     +211     
Flag Coverage Δ
unittests 67.05% <52.92%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chartserver/cache.go 53.16% <ø> (ø)
src/chartserver/handler_repo.go 83.33% <0.00%> (ø)
src/chartserver/redis_sentinel.go 0.88% <0.00%> (-0.02%) ⬇️
src/chartserver/reverse_proxy.go 56.73% <ø> (ø)
src/common/api/base.go 27.38% <ø> (ø)
src/common/dao/base.go 58.33% <ø> (ø)
src/common/dao/mysql.go 0.00% <ø> (ø)
src/common/dao/pgsql.go 72.46% <ø> (ø)
src/common/dao/resource_label.go 77.96% <ø> (ø)
src/common/dao/sqlite.go 0.00% <ø> (ø)
... and 486 more

@chlins
Copy link
Member

chlins commented Apr 6, 2022

@JinXingYoung Thanks! I think we need to add MySQL and MariaDB integration tests in the CI to ensure the feature works well, you can refer .github/workflows/CI.yaml.

@JinXingYoung
Copy link
Author

@JinXingYoung Thanks! I think we need to add MySQL and MariaDB integration tests in the CI to ensure the feature works well, you can refer .github/workflows/CI.yaml.

@chlins OK, I'll refer to CI.yaml and add some new tests.

@Vad1mo Vad1mo added the release-note/new-feature New Harbor Feature label Apr 26, 2022
@Vad1mo Vad1mo marked this pull request as draft April 26, 2022 15:15
@Vad1mo
Copy link
Member

Vad1mo commented Apr 26, 2022

I am marking this PR as draft for now

Signed-off-by: Yiyang Huang <huangyiyang.huangyy@bytedance.com>
Signed-off-by: yvonnexyang <yvonnexyang@tencent.com>
@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Jan 14, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Feb 13, 2023
@chlins chlins reopened this Feb 20, 2023
@github-actions github-actions bot removed the Stale label Feb 21, 2023
@github-actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Apr 23, 2023
@github-actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants