-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Multiple Type of Database #16615
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/multi-db #16615 +/- ##
=================================================
- Coverage 67.35% 67.05% -0.31%
=================================================
Files 953 979 +26
Lines 79016 82261 +3245
Branches 2331 2630 +299
=================================================
+ Hits 53221 55159 +1938
- Misses 22220 23316 +1096
- Partials 3575 3786 +211
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@JinXingYoung Thanks! I think we need to add MySQL and MariaDB integration tests in the CI to ensure the feature works well, you can refer |
@chlins OK, I'll refer to CI.yaml and add some new tests. |
06f8036
to
0b6e8a7
Compare
5114101
to
c8171ef
Compare
I am marking this PR as draft for now |
12d5d13
to
719c23e
Compare
a456002
to
e5742eb
Compare
48a4fae
to
4f6c757
Compare
5cf238b
to
098974d
Compare
Signed-off-by: Yiyang Huang <huangyiyang.huangyy@bytedance.com>
4e288f8
to
72c5206
Compare
Signed-off-by: yvonnexyang <yvonnexyang@tencent.com>
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Support MySQL and MariaDB
Related issue: #6534
Signed-off-by: yvonnexyang yvonnexyang@tencent.com