Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Pluggable Image Vulnerability Scanning #98

Merged
merged 18 commits into from
Oct 18, 2019
Merged

Proposal: Pluggable Image Vulnerability Scanning #98

merged 18 commits into from
Oct 18, 2019

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jul 31, 2019

This is a combination of #82 and #90 and PRD by Alex Xu.

The main file to read is proposals/pluggable-image-vulnerability-scanning_proposal.md.

@steven-zou steven-zou added kind/proposal area/interrogation-service Services like vulnerability scanning and compliance checking etc. labels Aug 5, 2019
@danielpacak danielpacak marked this pull request as ready for review August 7, 2019 19:47
Copy link

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress!

@xaleeks xaleeks self-requested a review August 8, 2019 12:46
@xaleeks xaleeks self-assigned this Aug 13, 2019
steven-zou
steven-zou previously approved these changes Oct 16, 2019
Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmpei
mmpei previously approved these changes Oct 16, 2019
Copy link
Contributor

@mmpei mmpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kofj
kofj previously approved these changes Oct 16, 2019
…n ScanRequest

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak dismissed stale reviews from kofj, mmpei, and steven-zou via 61475b6 October 16, 2019 14:03
Copy link
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou
Copy link
Contributor

steven-zou commented Oct 18, 2019

Hello, @goharbor/all-maintainers @lizrice @michmike @danfengliu @zhill

As we have got enough votes (4/5) now, this proposal is accepted and will be merged now. Thank you all for drafting, reviewing and voting!

@steven-zou steven-zou merged commit d394632 into goharbor:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/interrogation-service Services like vulnerability scanning and compliance checking etc. kind/proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants