Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate cloud event for webhook #213

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Feb 9, 2023

Link: goharbor/harbor#18209

Signed-off-by: chlins chenyuzh@vmware.com

@chlins chlins requested review from a team as code owners February 9, 2023 07:15
@chlins
Copy link
Member Author

chlins commented Feb 9, 2023

@goharbor/all-maintainers Please help to review this proposal, thanks!

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyload format name should be correctly set to "CloudEvents"

proposals/new/cloudevent.md Outdated Show resolved Hide resolved
Signed-off-by: chlins <chenyuzh@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
Copy link
Member Author

chlins commented Mar 14, 2023

@Vad1mo Hi, the comments have been resolved, please help to review again, thanks.

Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Vad1mo Vad1mo merged commit 3417fff into goharbor:main Mar 20, 2023
@OrlinVasilev
Copy link
Member

That's fantastic folks!!!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants