Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposal of robot account enhancement #148

Merged
merged 4 commits into from
May 25, 2021

Conversation

wy65701436
Copy link
Contributor

No description provided.

Signed-off-by: wang yan <wangyan@vmware.com>
2. As a system admin, I can edit a system level robot account to enhance/reduce the access scope.
3. As a system admin, I can edit a system level robot account to enhance/reduce the project scope.
4. As a system admin, I can extend the expiration data of a system level robot account.
5. As a system admin, I can view the token of a system level robot account and refresh the token.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall there's requirement to edit the token, for example I can set the password of a robot account to passw0rd

Robot Account is a System Administrator and Project Administrator operation in Harbor.

* User Stories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also requirement not forcing the user to use robot$xxxx as username?

/*
permissions string used as the access scope.
*/
permissions varchar(1024),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we extract the scope to another table?
In future we may associate such scopes with a customized role or access token that maybe shared by different Harbor instances.

/*
permissions string used as the access scope.
*/
permissions varchar(1024),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the permission conflicts with the project id?

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
@ChristianCiach
Copy link

ChristianCiach commented Oct 28, 2020

I just created the issue goharbor/harbor#13384. I am not sure why the robot user cannot currently be used to pull-replicate private projects, but I guess it has something to do with the /v2/_catalog endpoint that the robot user is not allowed to access. But this is just a guess.

@danielpacak danielpacak self-requested a review October 29, 2020 11:49

## Abstract

Robot account limited into one specific project, it cannot access multiple projects.
Copy link
Contributor

@danielpacak danielpacak Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wy65701436 Would it be possible to grant permissions to access registry catalog /v2/_catalog for such new robot account?

secret string used as the password of robot account.
For v2.2, it stores the secret.
*/
secret varchar(2048),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this is hash, not plain text.

* (P1)Whether to provide Kubernetes pull secret for the robot account.
* (P1)Whether to provide Docker credentials config for the robot account.

## Security Concern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the proposal to conclude how these concerns are addressed.

@dioguerra
Copy link

Is this coming with v2.2.0

@Vad1mo
Copy link
Member

Vad1mo commented Feb 9, 2021

Is this coming with v2.2.0

@mrd2 join tomorrow the community meeting at 14:00 CEST I’ll being that topic up. As we need that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants