Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape the HTML in the editor of the posts and post carousel blocks #2618

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Escape the HTML in the editor of the posts and post carousel blocks #2618

merged 7 commits into from
Jul 25, 2024

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Jul 25, 2024 •
edited
Loading

Description

Ensure that the excerpts inside of the posts and post carousel blocks are properly escaped.

Additionally fixed the e2e tests for WordPress 6.6. (Merged changes from WP66-beta1 branch here.

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Tested using various HTML markup in the excerpt of posts.

Checklist:

  • My code is tested
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Jul 25, 2024
@EvanHerman EvanHerman added this to the Next Release milestone Jul 25, 2024
@EvanHerman EvanHerman self-assigned this Jul 25, 2024
@EvanHerman EvanHerman modified the milestones: Next Release, 3.1.13 Jul 25, 2024
AnthonyLedesma
AnthonyLedesma approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix the issue. I am going to attribute the folks who helped us out here upon release

@EvanHerman EvanHerman merged commit 2046d80 into master Jul 25, 2024
65 checks passed
@EvanHerman EvanHerman deleted the escape-html-post-blocks branch July 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLedesma AnthonyLedesma AnthonyLedesma approved these changes

@snovosel snovosel Awaiting requested review from snovosel

Assignees

@EvanHerman EvanHerman

Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Milestone
3.1.13
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanHerman @AnthonyLedesma @olafleur-godaddy