cherry-pick: API BREAK: use unsigned types for 1-bit fields of 'obj_state_s' #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
force-pushed
the
bitfield_proper_set
branch
2 times, most recently
from
30f1f96
to
08d8187
Compare
edaniels
changed the title
|
@goccy just bumping for your attention. Thank you for your work! |
|
thanks @edaniels can confirm this fixed things for me. rm -rf go-graphviz
git clone https://github.com/edaniels/go-graphviz -b bitfield_proper_set
@echo go-graphviz >> .gitignore
touch go.work
go work use go-graphviz
cd go-graphviz/cmd/dot && go build .
|
|
@edaniels Sorry for late reply. Looks good to me this changes, but I couldn't confirm any CI logs, so please push empty commit and re-run CI. |
edaniels
force-pushed
the
bitfield_proper_set
branch
from
08d8187
to
b28a42b
Compare
|
@goccy done. Looks like it needs your approval to start. |
|
Thank you for your contribution ! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80
@thomasfleming-cs, probably still better to update the vendored library all together but this is tiny to start