Fix various issues that golint complains about

default_context_test.go

@@ -143,7 +143,7 @@ func Test_DefaultContext_GetSet(t *testing.T) {
 	r.Equal("Mark", c.Value("name").(string))
 }
 
-func Test_DefaultContext_Set_Unconfigured(t *testing.T) {
+func Test_DefaultContext_Set_not_configured(t *testing.T) {
 	r := require.New(t)
 	c := DefaultContext{}
 
@@ -162,7 +162,7 @@ func Test_DefaultContext_Value(t *testing.T) {
 	r.Equal("Mark", c.Value("name").(string))
 }
 
-func Test_DefaultContext_Value_Unconfigured(t *testing.T) {
+func Test_DefaultContext_Value_not_configured(t *testing.T) {
 	r := require.New(t)
 	c := DefaultContext{}
 	r.Nil(c.Value("name"))
@@ -323,7 +323,7 @@ func Test_DefaultContext_Data(t *testing.T) {
 	r.EqualValues(map[string]interface{}{}, c.Data())
 }
 
-func Test_DefaultContext_Data_Unconfigured(t *testing.T) {
+func Test_DefaultContext_Data_not_configured(t *testing.T) {
 	r := require.New(t)
 	c := DefaultContext{}
 
@@ -345,7 +345,7 @@ func Test_DefaultContext_String_EmptyData(t *testing.T) {
 	r.EqualValues("", c.String())
 }
 
-func Test_DefaultContext_String_EmptyData_Unconfigured(t *testing.T) {
+func Test_DefaultContext_String_EmptyData_not_configured(t *testing.T) {
 	r := require.New(t)
 	c := DefaultContext{}
 
@@ -372,7 +372,7 @@ func Test_DefaultContext_MarshalJSON_EmptyData(t *testing.T) {
 	r.EqualValues(`{}`, string(jb))
 }
 
-func Test_DefaultContext_MarshalJSON_EmptyData_Unconfigured(t *testing.T) {
+func Test_DefaultContext_MarshalJSON_EmptyData_not_configured(t *testing.T) {
 	r := require.New(t)
 	c := DefaultContext{}
 

home.go

@@ -14,7 +14,7 @@ import (
    could be strage.
 */
 
-// Home is a container for Domains and Groups that independantly serves a
+// Home is a container for Domains and Groups that independently serves a
 // group of pages with its own Middleware and ErrorHandlers. It is usually
 // a multi-homed server domain or group of paths under a certain prefix.
 //

mail/internal/mail/mime.go

@@ -1,6 +1,3 @@
-//go:build go1.5
-// +build go1.5
-
 package mail
 
 import (

plugins/log.go

@@ -1,4 +1,4 @@
-//+build !debug
+// +build !debug
 
 package plugins
 

plugins/log_debug.go

@@ -1,4 +1,4 @@
-//+build debug
+// +build debug
 
 package plugins
 

plugins/plugdeps/plugdeps.go

@@ -13,7 +13,7 @@ import (
 // ErrMissingConfig is if config/buffalo-plugins.toml file is not found. Use plugdeps#On(app) to test if plugdeps are being used
 var ErrMissingConfig = fmt.Errorf("could not find a buffalo-plugins config file at %s", ConfigPath(meta.New(".")))
 
-// List all of the plugins the application depeneds on. Will return ErrMissingConfig
+// List all of the plugins the application depends on. Will return ErrMissingConfig
 // if the app is not using config/buffalo-plugins.toml to manage their plugins.
 // Use plugdeps#On(app) to test if plugdeps are being used.
 func List(app meta.App) (*Plugins, error) {
@@ -46,11 +46,11 @@ func List(app meta.App) (*Plugins, error) {
 
 func listLocal(app meta.App) (*Plugins, error) {
 	plugs := New()
-	proot := filepath.Join(app.Root, "plugins")
-	if _, err := os.Stat(proot); err != nil {
+	pRoot := filepath.Join(app.Root, "plugins")
+	if _, err := os.Stat(pRoot); err != nil {
 		return plugs, nil
 	}
-	err := filepath.WalkDir(proot, func(path string, d fs.DirEntry, err error) error {
+	err := filepath.WalkDir(pRoot, func(path string, d fs.DirEntry, err error) error {
 		if d.IsDir() {
 			return nil
 		}

plugins/plugdeps/plugins.go

@@ -32,7 +32,7 @@ func (plugs *Plugins) Decode(r io.Reader) error {
 	tp := &tomlPlugins{
 		Plugins: []Plugin{},
 	}
-	if _, err := toml.DecodeReader(r, tp); err != nil {
+	if _, err := toml.NewDecoder(r).Decode(tp); err != nil {
 		return err
 	}
 	for _, p := range tp.Plugins {

server_test.go

@@ -16,9 +16,9 @@ import (
 // timing sensitive. Adjust this timing values if they are failing due to
 // timing issue.
 const (
-	WAIT_START   = 2
-	WAIT_RUN     = 2
-	CONSUMER_RUN = 8
+	waitStart   = 2
+	waitRun     = 2
+	consumerRun = 8
 )
 
 // startApp starts given buffalo app and check its exit status.
@@ -32,7 +32,7 @@ func startApp(app *App, wg *sync.WaitGroup, r *require.Assertions) {
 	}()
 	// wait until the server started.
 	// could be improved with connection test but that's too much...
-	time.Sleep(WAIT_START * time.Second)
+	time.Sleep(waitStart * time.Second)
 }
 
 func Test_Server_Simple(t *testing.T) {
@@ -55,7 +55,7 @@ var handlerDone = false
 
 // timeConsumer consumes about 10 minutes for processing its request
 func timeConsumer(c Context) error {
-	for i := 0; i < CONSUMER_RUN; i++ {
+	for i := 0; i < consumerRun; i++ {
 		fmt.Println("#")
 		time.Sleep(1 * time.Second)
 	}
@@ -89,7 +89,7 @@ func Test_Server_GracefulShutdownOngoingRequest(t *testing.T) {
 		firstQuery = true
 	}()
 	// make sure the request sent
-	time.Sleep(WAIT_RUN * time.Second)
+	time.Sleep(waitRun * time.Second)
 
 	app.cancel()
 	time.Sleep(1 * time.Second) // make sure the server started shutdown.
@@ -114,7 +114,7 @@ func Test_Server_GracefulShutdownOngoingRequest(t *testing.T) {
 var timerDone = false
 
 func timerWorker(args worker.Args) error {
-	for i := 0; i < CONSUMER_RUN; i++ {
+	for i := 0; i < consumerRun; i++ {
 		fmt.Println("%")
 		time.Sleep(1 * time.Second)
 	}