Add Inplace Variable Introduce refactoring #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| else if (expressions.size() == 1) { | ||
| GoExpression expression = ContainerUtil.getFirstItem(expressions); | ||
| if (expression == null) { |
There was a problem hiding this comment.
Any chance to have a list of null values here?
auduchinok
force-pushed
the
extract_variable_refactoring
branch
6 times, most recently
from
30b9eb8
to
a4380fb
Compare
| if (!CommonRefactoringUtil.checkReadOnlyStatus(file)) return; | ||
| if (editor.getSettings().isVariableInplaceRenameEnabled()) { | ||
| final TemplateState templateState = TemplateManagerImpl.getTemplateState(editor); | ||
| if (templateState != null && !templateState.isFinished()) return; |
|
selection-tests are needed return PsiTreeUtil.findElementOfClassAtRange(operation.getFile(), selectionModel.getSelectionStart(), selectionModel.getSelectionEnd(),
GoExpression.class); |
| if (element instanceof PsiWhiteSpace || (parenthesesParent != null && parenthesesParent.getRparen() == element)) { | ||
| element = file.findElementAt(offset - 1); | ||
| } | ||
| return element instanceof GoExpression ? (GoExpression)element : PsiTreeUtil.getParentOfType(element, GoExpression.class); |
|
Cannot perform refactoring: package main
func main() {
println(3<caret>)
} |
|
Wrong result package main
func main() {
i := test()
}
func test() int {
} |
| return true; | ||
| } | ||
|
|
||
| private static PsiElement findAnchor(@NotNull List<PsiElement> occurrences) { |
There was a problem hiding this comment.
optimize with PsiTreeUtil.findCommonParent(occurrences)
auduchinok
force-pushed
the
extract_variable_refactoring
branch
2 times, most recently
from
5d1bb5a
to
f339631
Compare
auduchinok
force-pushed
the
extract_variable_refactoring
branch
2 times, most recently
from
eb2eba3
to
729aa51
Compare
Refactor and fix Fix test Annotate Introduce Operation
auduchinok
force-pushed
the
extract_variable_refactoring
branch
from
729aa51
to
bc4e128
Compare
zolotov
added a commit
that referenced
this pull request
Aug 3, 2015
…ctoring Add Inplace Variable Introduce refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs adding tests and probably introduce using dialog.