Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use callbacks.Begin as a hook to handle begin operation #5492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sunfuze
Copy link
Contributor

@sunfuze sunfuze commented Jul 6, 2022

make transaction support hooks

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Use callbacks.Begin as hook to handle real transaction operation, make transaction support before/after hooks.

User Case Description

  • Database sharding: shard database by info in context
  • Implement distributed transaction

@jinzhu
Copy link
Member

jinzhu commented Jul 14, 2022

notes to myself:

The Transaction hooks API will be behaves like:

tx := db.Scopes(OnTransaction{
       OnCommit: func(tx *gorm.TransactionInterface) {
               // xxx
               tx.Commit()
               // xxx
       },
       OnRollback: func(tx *gorm.TransactionInterface) {
               // xxx
               tx.Rollback()
               // xxx
       },
       OnBegin: func(db *gorm.DBInterface) {
               // xxx
               tx.Begin()
               // xxx
       },
}).Begin()

tx.Commit()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants