Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release API URL generation #8239

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Fix release API URL generation #8239

merged 2 commits into from
Sep 19, 2019

Conversation

danielflira
Copy link
Contributor

This PR is related to PR #8234

When I configure the repository to send a release webhook, the URL key is generated without repos/ resulting in a wrong API URL. Example:

Actual:

{
    "url": "https://try.gitea.io/api/v1/danielflira/test123/releases/3281557"
}

Fixed:

{
    "url": "http://localhost:3000/api/v1/repos/danielflira/test123/releases/1"
}

@lafriks lafriks added modifies/api This PR adds API routes or modifies them type/bug labels Sep 19, 2019
@lafriks lafriks added this to the 1.9.4 milestone Sep 19, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 19, 2019
@techknowlogick techknowlogick merged commit 0ed5a64 into go-gitea:release/v1.9 Sep 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants