Added download tooltip - solves #221 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
tboerger
reviewed
Dec 7, 2016
| @@ -69,7 +69,7 @@ | |||
| <button class="ui basic icon button poping up clipboard" id="clipboard-btn" data-original="{{.i18n.Tr "repo.copy_link"}}" data-success="{{.i18n.Tr "repo.copy_link_success"}}" data-error="{{.i18n.Tr "repo.copy_link_error"}}" data-content="{{.i18n.Tr "repo.copy_link"}}" data-variation="inverted tiny" data-clipboard-target="#repo-clone-url"> | |||
| <i class="octicon octicon-clippy"></i> | |||
| </button> | |||
| <div class="ui basic jump dropdown icon button"> | |||
| <div class="ui basic jump dropdown icon button poping up" data-content="{{.i18n.Tr "repo.download_archive"}}" data-variation="tiny inverted"> | |||
There was a problem hiding this comment.
Yeah, that's because I'm used to use whitespaces not tabs...will fix it.
|
Tiny nitpicking, otherwise LGTM |
tboerger
added
modifies/translation
topic/ui
hhenkel
force-pushed
the
feature/download_tooltip
branch
from
3e8c1c9
to
e05fd76
Compare
|
Perfect, thanks! |
|
It's missing the bindata update :( |
hhenkel
added a commit
to hhenkel/gitea
that referenced
this pull request
Dec 7, 2016
lunny
pushed a commit
that referenced
this pull request
Dec 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #221.