Fix Bug in Issue/pulls list #32081
Open
Fix Bug in Issue/pulls list #32081
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Open/Closed status
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
techknowlogick
added
type/bug
topic/ui
lunny
reviewed
Sep 20, 2024
routers/web/repo/issue.go
Outdated
| @@ -467,6 +467,9 @@ func issues(ctx *context.Context, milestoneID, projectID int64, isPullOption opt | |||
| ctx.Data["AssigneeID"] = assigneeID | |||
| ctx.Data["PosterID"] = posterID | |||
| ctx.Data["Keyword"] = keyword | |||
| if isShowClosed.Has() { | |||
| ctx.Data["IsShowClosed"] = isShowClosed.Value() | |||
There was a problem hiding this comment.
I think since IsShowClosed has 3 states, it's better to change the template. the current implementation has only two states. ctx.Data["IsShowClosed"] = false is equal to not set the template variable.
There was a problem hiding this comment.
As far as I know when state query parameter is not setted (that also means IsShowClosed does not have a value), issue list shows opened issues.
I think in that case, ctx.Data["IsShowClosed"] = false doesn't seemed to be error prone.
Is there are any edge cases that i'm missing?
I found a edge case that select all issue. in that case I'll make not to show open or close button. Is that would be ok?
github-actions
bot
added
the
modifies/templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #32080
After
for opened issues
for closed issues
for all issues