Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] missing ctx in new_form #27514

Merged
merged 2 commits into from
Oct 8, 2023
Merged

[FIX] missing ctx in new_form #27514

merged 2 commits into from
Oct 8, 2023

Conversation

mohammedahmed18
Copy link
Contributor

added the ctx for the project link in new_form.tmpl

Screenshot_20231008_075757

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 8, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 8, 2023
@techknowlogick techknowlogick added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 8, 2023
@mohammedahmed18
Copy link
Contributor Author

@lng2020
Question: I just started looking into the Gitea project and I've noticed that there are quite a few issues related to the same 'missing ctx' error.
I'm wondering what is the reason these errors are being overlooked so frequently and not noticed earlier.

@lng2020
Copy link
Member

lng2020 commented Oct 8, 2023

@lng2020 Question: I just started looking into the Gitea project and I've noticed that there are quite a few issues related to the same 'missing ctx' error. I'm wondering what is the reason these errors are being overlooked so frequently and not noticed earlier.

Currently, we are refactoring about db context(#27065), which inevitably causes some issues. The version before 1.21 does not include this refactoration, so there are not such issues.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 8, 2023
@lunny lunny merged commit 551dc8b into go-gitea:main Oct 8, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 8, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 8, 2023

I was unable to create a backport for 1.21. @mohammedahmed18, please send one manually. 🍵

go run ./contrib/backport 27514
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 8, 2023
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 8, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 8, 2023
@delvh delvh added topic/ui Change the appearance of the Gitea UI and removed kind/ui labels Oct 8, 2023
@mohammedahmed18 mohammedahmed18 deleted the mohammed/fix-missing-ctx-in-new-form branch October 8, 2023 08:40
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 10, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
087dfb1 
* giteaofficial/main:
  Respect SSH.KeygenPath option when calculating ssh key fingerprints (go-gitea#27536)
  Remove max-width and add hide text overflow (go-gitea#27359)
  Fix `environment-to-ini` inherited key bug (go-gitea#27543)
  Improve docs about register/run as a service (go-gitea#27461)
  api: GetPullRequestCommits: return file list (go-gitea#27483)
  switch to using official AWS step in release nightly (go-gitea#27532)
  Improve file history UI and fix URL escaping bug (go-gitea#27531)
  Improve dropdown's behavior when there is a search input in menu (go-gitea#27526)
  Simplify `contrib/backport` (go-gitea#27520)
  Add docs section for sub-paths with the container registry (go-gitea#27505)
  Document our new labeling strategy (go-gitea#27523)
  [skip ci] Updated translations via Crowdin
  Restore warning commit status (go-gitea#27504)
  Update labeler to match new labeling system (go-gitea#27525)
  Apply to become a maintainer (go-gitea#27522)
  Remove unnecessary desc for openssh key cron task (go-gitea#27515)
  Tweak labeler config (go-gitea#27502)
  Add hover background to wiki list page (go-gitea#27507)
  [FIX] missing ctx in new_form (go-gitea#27514)
@lng2020 lng2020 mentioned this pull request Oct 14, 2023
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 14, 2023
lunny pushed a commit that referenced this pull request Oct 14, 2023
@lng2020
Backport manually for a tmpl issue in v1.21 (#27612)
fa6941c 
backport #27514 
close #27607
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mohammedahmed18 @lng2020 @GiteaBot @lunny @techknowlogick @delvh