Move licenses.txt to /assets directory #26866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
|
Isn't the actual |
silverwind
changed the title
|
No, the file is fabricated during webpack build, it does not exist anywhere else. |
|
But we might need to gitignore it now :D |
delvh
approved these changes
Sep 1, 2023
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Sep 1, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
type/refactoring
techknowlogick
added
the
reviewed/wait-merge
GiteaBot
added
the
lgtm/done
wxiaoguang
removed
the
reviewed/wait-merge
wxiaoguang
reviewed
Sep 1, 2023
| @@ -23,7 +23,7 @@ | |||
| {{end}} | |||
| </div> | |||
| </div> | |||
| <a href="{{AssetUrlPrefix}}/js/licenses.txt">{{.locale.Tr "licenses"}}</a> | |||
| <a href="{{AssetUrlPrefix}}/licenses.txt">{{.locale.Tr "licenses"}}</a> | |||
There was a problem hiding this comment.
A longstanding question in my mind: this "license" file only contains frontend licenses? If not so, then it looks good to me.
If this file is frontend-only, does it need to show backend licenses?
There was a problem hiding this comment.
This file contains both frontend and backend licenses (extracted from assets/go-licenses.json).
wxiaoguang
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 4, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Update documents to fix some links (go-gitea#26885) clarify aspects of the dump command (go-gitea#26887) Relocate the `RSS user feed` button (go-gitea#26882) Use Go 1.21 and update dependencies (go-gitea#26878) Update docs about attachment path (go-gitea#26883) Refactor "shortsha" (go-gitea#26877) Fix wrong review requested number (go-gitea#26784) Refactor `og:description` to limit the max length (go-gitea#26876) Reorder blocks in vue SFCs (go-gitea#26874) Make it posible to customize nav text color via css var (go-gitea#26807) Enable djlint H008 and fix issues (go-gitea#26869) Improve opengraph previews (go-gitea#26851) Add more descriptive error on forgot password page (go-gitea#26848) Allow users with write permissions for issues to add attachments with API (go-gitea#26837) Move licenses.txt to /assets directory (go-gitea#26866) # Conflicts: # templates/base/footer_content.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the
/assetsdirectory, we can putlicenses.txtdirectly into it instead of incorrect/jspath which was previously only done to avoid reserving a username.