Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict certificate type for builtin SSH server #26789

Merged
merged 2 commits into from
Sep 1, 2023

Commits on Aug 29, 2023

  1. restrict certificate type for builtin SSH server

    - While doing some sanity checks over OpenSSH's code for how they
    handle certificates authentication. I stumbled on an condition that
    checks the certificate type is really an user certificate on the
    server-side authentication. This checks seems to be a formality and just
    for the sake of good domain seperation, because an user and host
    certificate don't differ in their generation, verification or flags that
    can be included.
    - Add this check to the builtin SSH server to stay close to the
    unwritten SSH specification.
    - This is an breaking change for setups where the builtin SSH server is
    being used and for some reason host certificates were being used for
    authentication.
    
    (cherry picked from commit de35b141b79a3d6efe2127ed2c73fd481515e481)
    
    Refs: https://codeberg.org/forgejo/forgejo/pulls/1172
    Gusted authored and earl-warren committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    12eb64d View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    e459885 View commit details
    Browse the repository at this point in the history