Merge templates/projects/list.tmpl and templates/repo/projects/list.tmpl together
#26265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 473862a1d599382ca022482e2e044025872d240b) Refs: https://codeberg.org/forgejo/forgejo/pulls/1126
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
wxiaoguang
approved these changes
Aug 1, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Thanks to both of you, earl and louis, now I have less work to do (#25123 (comment)).
I don't know why the solution works but I'm fine with it working. I didn't expect it to be that easy, it looked like that would need a lot more changes…
The only thing that remains for my point
Merging the separate project templates together
Is the actual display of one project (templates/projects/view.tmpl vs templates/repo/projects/view.tmpl). Merging Creation/Edits and List are already done then…
GiteaBot
added
lgtm/done
delvh
changed the title
templates/project/list.tmpl and templates/repo/projects/list.tmpl together
delvh
changed the title
templates/project/list.tmpl and templates/repo/projects/list.tmpl togethertemplates/projects/list.tmpl and templates/repo/projects/list.tmpl together
lunny
approved these changes
Aug 1, 2023
lunny
added
type/bug
type/refactoring
|
It also fixed some bugs. |
|
The bug could be backport to v1.20 but I don't whether the refacto can do also. |
|
Which bug did it fix? |
lunny
previously requested changes
Aug 1, 2023
GiteaBot
added
lgtm/blocked
GiteaBot
added
lgtm/done
wxiaoguang
added
the
reviewed/wait-merge
|
I was unable to create a backport for 1.20. @earl-warren, please send one manually. 🍵 |
GiteaBot
added
backport/manual
|
Why do we backport a refactor? 😳 |
|
Well, I don't know either. |
|
It checks the archive repositories to prevent to display the |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 2, 2023
* upstream/main: Clarify the logger's MODE config option (go-gitea#26267) speed up TestEventSourceManagerRun (go-gitea#26262) Merge `templates/projects/list.tmpl` and `templates/repo/projects/list.tmpl` together (go-gitea#26265) Allow editing push mirrors after creation (go-gitea#26151) Update Arch linux URL from community to extra (go-gitea#26273) Fix due date rendering the wrong date in issue (go-gitea#26268) Some fixes of the prompt of new branches (go-gitea#26257)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 473862a1d599382ca022482e2e044025872d240b)
Refs: https://codeberg.org/forgejo/forgejo/pulls/1126