Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ctx.Written() for GetActionIssue (#25698) #25714

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Check ctx.Written() for GetActionIssue (#25698) #25714

merged 2 commits into from
Jul 7, 2023

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Jul 6, 2023

Backport #25698.

Fix #25697.

Just avoid panic, maybe there's another bug to trigger this case.

@wolfogre @GiteaBot
Check ctx.Written() for GetActionIssue (#25698)
a96aa15 
Fix #25697.

Just avoid panic, maybe there's another bug to trigger this case.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@wolfogre wolfogre added this to the 1.19.5 milestone Jul 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 6, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 7, 2023
@silverwind silverwind merged commit 53276d3 into go-gitea:release/v1.19 Jul 7, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 7, 2023
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Jul 12, 2023
@wolfogre @earl-warren
Check ctx.Written() for GetActionIssue (go-gitea#25698) (go-gitea…
d64417a 
…#25714)

Backport go-gitea#25698.

Fix go-gitea#25697.

Just avoid panic, maybe there's another bug to trigger this case.

Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit 53276d3)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.19.5
Development

Successfully merging this pull request may close these issues.
4 participants
@wolfogre @lunny @silverwind @GiteaBot