Allow new file and edit file preview if it has editable extension #23624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
reviewed
Mar 22, 2023
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Mar 22, 2023
wxiaoguang
reviewed
Mar 22, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23624 +/- ##
========================================
Coverage 47.14% 47.14%
========================================
Files 1149 1155 +6
Lines 151446 152396 +950
========================================
+ Hits 71397 71852 +455
- Misses 71611 72059 +448
- Partials 8438 8485 +47
... and 44 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
silverwind
reviewed
Mar 22, 2023
wxiaoguang
reviewed
Mar 23, 2023
lunny
approved these changes
Mar 24, 2023
GiteaBot
added
lgtm/need 1
HesterG
force-pushed
the
newfile-preview-23579
branch
from
118e023
to
8846ca3
Compare
silverwind
approved these changes
Mar 25, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 27, 2023
* upstream/main: (23 commits) Fix project card preview select and template select (go-gitea#23684) [skip ci] Updated translations via Crowdin Add git dashes separator to some "log" and "diff" commands (go-gitea#23606) Add Simplified Chinese translate for oauth2-provider (go-gitea#23713) Fix incorrect `toggle` buttons (go-gitea#23676) Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form (go-gitea#23626) Allow new file and edit file preview if it has editable extension (go-gitea#23624) [skip ci] Updated translations via Crowdin Clean some legacy files and move some build files (go-gitea#23699) Remove row clicking from notification table (go-gitea#22695) Describe Gitea's purpose more accurately (go-gitea#23698) [skip ci] Updated translations via Crowdin ensure go/bin path exists when copying hugo bin into it (go-gitea#23692) Create commit status when event is `pull_request_sync` (go-gitea#23683) Add `deps-docs` command to makefile (go-gitea#23686) Fix incorrect package doc link (go-gitea#23679) Improve indices for `action` table (go-gitea#23532) Clarify that Gitea requires JavaScript (go-gitea#23677) Use data-tooltip-content for tippy tooltip (go-gitea#23649) Add aria attributes to interactive time tooltips. (go-gitea#23661) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #23579
Inspired by idea from @brechtvl
In this PR, the behavior is when extension switches from writatble to not, preview will hide, and vice versa.
demo:
default.mov