Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest metadata in refactoring docs #23087

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

techknowlogick
Copy link
Member

Whitespace was missing from refactoring docs metadata.

backport label applied so it is included in versioned docs.

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Feb 23, 2023
@techknowlogick techknowlogick modified the milestones: 1.19.0, 1.20.0 Feb 23, 2023
@wxiaoguang
Copy link
Contributor

Thank you. I just had some thoughts about that the refactoring guideline should be clarified about:

  • It's recommended to do refactoring after the second stable release.

For example:

Now 1.19 is releasing, if a refactoring PR is big, it should be done after 1.19.1, this will make bug fixes for 1.19.1 could be backported easily. Because only after 1.19.0 released, there are enough users to use and report bugs.

If a big refactoring PR is merged into 1.20-dev before 1.19.1, then the backporting of bug fixes for 1.19.1 would cause many conflicts.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2023
@lunny lunny merged commit dd7d6e3 into go-gitea:main Feb 23, 2023
yardenshoham pushed a commit to yardenshoham/gitea that referenced this pull request Feb 23, 2023
Whitespace was missing from refactoring docs metadata.

backport label applied so it is included in versioned docs.
@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label Feb 23, 2023
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch February 23, 2023 08:37
techknowlogick added a commit that referenced this pull request Feb 23, 2023
Backport #23087

Whitespace was missing from refactoring docs metadata.

backport label applied so it is included in versioned docs.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2023
* giteaofficial/main:
  Make issue meta dropdown support Enter, confirm before reloading (go-gitea#23014)
  Fix SyncOnCommit always return false in API of push_mirrors (go-gitea#23088)
  Fix commit name in Apply Patch page (go-gitea#23086)
  Add wrapper to author to avoid long name ui problem (go-gitea#23030)
  Avoid Hugo from adding quote to actions url (go-gitea#23097)
  Remove all package data after tests (go-gitea#22984)
  Change style to improve whitespaces trimming inside inline markdown code  (go-gitea#23093)
  Nest metadata in refactoring docs (go-gitea#23087)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants