Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the show/hide methods for string selector #23042

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Fix the show/hide methods for string selector #23042

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
047b92d
fix
wxiaoguang Feb 21, 2023
ccab720
Merge branch 'main' into fix-toggle-elem
delvh Feb 21, 2023
9aa75af
Merge branch 'main' into fix-toggle-elem
delvh Feb 21, 2023
9ba3198
Merge branch 'main' into fix-toggle-elem
jolheiser Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web_src/js/utils/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function assertShown(el, expectShown) {
}

function elementsCall(el, func, ...args) {
if (el instanceof String) {
if (typeof el === 'string' || el instanceof String) {
delvh marked this conversation as resolved.
Show resolved Hide resolved
el = document.querySelectorAll(el);
}
if (el instanceof Node) {
Expand All @@ -34,6 +34,10 @@ function elementsCall(el, func, ...args) {
}
}

/**
* @param el string (selector), Node, NodeList, HTMLCollection, Array or jQuery
* @param force force=true to show or force=false to hide, undefined to toggle
*/
function toggleShown(el, force) {
if (force === true) {
el.classList.remove('gt-hidden');
Expand Down