Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 500 error when view an issue which's milestone deleted #2297

Merged
merged 1 commit into from
Aug 12, 2017
Merged

fix 500 error when view an issue which's milestone deleted #2297

merged 1 commit into from
Aug 12, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 11, 2017

Will fix #2294 and should be back ported to v1.1

@lunny lunny added this to the 1.2.0 milestone Aug 11, 2017
@andreynering
Copy link
Contributor

Trusted LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 12, 2017
@ethantkoenig
Copy link
Member

ethantkoenig commented Aug 12, 2017 •
edited
Loading

I don't believe this will fix #2294. The MilestoneID field of issues is set to 0 when the milestone is deleted (see DeleteMilestoneByRepoID(..)). I think instead that #2294 is caused because v1.1 does not have #1942.

That being said, this is still a good check to have, so LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 12, 2017
@lunny
Copy link
Member Author

lunny commented Aug 12, 2017

@ethantkoenig So maybe we need send a back port from #1942 to v1.1.

@lunny lunny merged commit 921d90f into go-gitea:master Aug 12, 2017
@lunny lunny deleted the lunny/fix_load_deleted_milestone branch August 12, 2017 02:15
lunny added a commit to lunny/gitea that referenced this pull request Aug 13, 2017
@lunny
fix 500 error when view an issue which's milestone deleted (go-gitea#…
d9baa1a 
…2297)
@lunny lunny mentioned this pull request Aug 13, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Aug 13, 2017
lunny added a commit that referenced this pull request Aug 14, 2017
@lunny
fix 500 error when view an issue which's milestone deleted (#2297) (#…
09fff9e 
…2299)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Error 500 when opening Issues connected to a deleted Milestone
4 participants
@lunny @andreynering @ethantkoenig @tboerger