Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stylesheet HTML snippet for external renderers documentation #22435

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Fix stylesheet HTML snippet for external renderers documentation #22435

merged 3 commits into from
Jan 13, 2023

Conversation

sbannier
Copy link
Contributor

The documentation is missing the rel attribute. Neither Firefox nor Chrome did use the linked file as CSS if rel="stylesheet" is not set.

The problem is described in issue #22434.

The documentation is missing the rel attribute. Neither Firefox nor
Chrome did use the linked file as CSS if rel="stylesheet" is not set.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2023
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after suggestion.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2023
@silverwind silverwind added the type/docs This PR mainly updates/creates documentation label Jan 13, 2023
text/css seems to be the default type, so this information is redundant.

Co-authored-by: silverwind <me@silverwind.io>
@sbannier
Copy link
Contributor Author

Thanks for the feedback, I changed the code as proposed by you. Shall I squash both commits or is the PR good the way it is now?

@silverwind
Copy link
Member

Not necessary as we squash on merge.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 13, 2023
@zeripath zeripath merged commit 20e3ffd into go-gitea:main Jan 13, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2023
* upstream/main:
  Prevent panic on looking at api "git" endpoints for empty repos (go-gitea#22457)
  Restore previous official review when an official review is deleted (go-gitea#22449)
  Add support for incoming emails (go-gitea#22056)
  Fix stylesheet HTML snippet for external renderers documentation (go-gitea#22435)
  Log STDERR of external renderer when it fails (go-gitea#22442)
  Fix error when calculate the repository size (go-gitea#22392)
  clarify "open issues" text for labels (go-gitea#22431)
  Restore function to "Show more" buttons (go-gitea#22399)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants