fix: avoid frequent string2bytes conversions #20940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
approved these changes
Aug 24, 2022
GiteaBot
added
the
lgtm/need 1
|
It should be possible to further improve this by using a technique that will avoid the allocation of the []byte slice. |
zeripath
added
performance/speed
lunny
approved these changes
Aug 24, 2022
GiteaBot
added
lgtm/done
delvh
approved these changes
Aug 24, 2022
|
BTW There will be other performance improvements in this code. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 25, 2022
* upstream/main: Fix input.value attr for RequiredClaimName/Value (go-gitea#20946) Move some files into models' sub packages (go-gitea#20262) [skip ci] Updated translations via Crowdin docs[zh-cn]: Install on Kubernetes (go-gitea#20874) Return 404 NotFound if requested attachment does not exist (go-gitea#20886) Avoid frequent string2bytes conversions (go-gitea#20940)
lafriks
approved these changes
Aug 28, 2022
|
How do you approve a PR 4 days after it has been merged? |
|
Yeah, I did not notice in GitHub mobile app it was already merged 😅 |
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20939
Every time the pos moves, then whole string will be converted to bytes, when the data is huge, it will be very slow.
Related to #19990