Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh #20902

Merged
merged 5 commits into from
Sep 4, 2022
Merged

Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh #20902

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b57e360
Set uploadpack.allowFilter etc on gitconfig to enable partial clones …
zeripath Aug 21, 2022
d6271ec
Merge branch 'main' into fix-20400-enable-partial-clones-with-gitea-serv
zeripath Aug 27, 2022
46dbdcb
Merge branch 'main' into fix-20400-enable-partial-clones-with-gitea-serv
zeripath Sep 3, 2022
3d100a1
Merge branch 'main' into fix-20400-enable-partial-clones-with-gitea-serv
zeripath Sep 4, 2022
dd55263
Merge branch 'main' into fix-20400-enable-partial-clones-with-gitea-serv
zeripath Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions modules/git/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,6 @@ func InitFull(ctx context.Context) (err error) {
globalCommandArgs = append(globalCommandArgs, "-c", "protocol.version=2")
}

// By default partial clones are disabled, enable them from git v2.22
if !setting.Git.DisablePartialClone && CheckGitVersionAtLeast("2.22") == nil {
globalCommandArgs = append(globalCommandArgs, "-c", "uploadpack.allowfilter=true", "-c", "uploadpack.allowAnySHA1InWant=true")
}

// Explicitly disable credential helper, otherwise Git credentials might leak
if CheckGitVersionAtLeast("2.9") == nil {
globalCommandArgs = append(globalCommandArgs, "-c", "credential.helper=")
Expand Down Expand Up @@ -286,7 +281,20 @@ func syncGitConfig() (err error) {
}
}

return nil
// By default partial clones are disabled, enable them from git v2.22
if !setting.Git.DisablePartialClone && CheckGitVersionAtLeast("2.22") == nil {
if err = configSet("uploadpack.allowfilter", "true"); err != nil {
return err
}
err = configSet("uploadpack.allowAnySHA1InWant", "true")
} else {
if err = configUnsetAll("uploadpack.allowfilter", "true"); err != nil {
return err
}
err = configUnsetAll("uploadpack.allowAnySHA1InWant", "true")
}

return err
}

// CheckGitVersionAtLeast check git version is at least the constraint version
Expand Down