Fix disabled open in vscode menu when disabling download source from UI

[lunny]

Fix #20579 (comment)

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@ccf03e1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9815cf9 differs from pull request most recent head ee2004f. Consider uploading reports for the commit ee2004f to get more accurate results

@@           Coverage Diff           @@
##             main   #20713   +/-   ##
=======================================
  Coverage        ?   46.92%           
=======================================
  Files           ?      981           
  Lines           ?   136262           
  Branches        ?        0           
=======================================
  Hits            ?    63937           
  Misses          ?    64477           
  Partials        ?     7848           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Gusted]

Inline scripts, is that necessary? Is it possible to wrap a <a href=....> into this element?

[lunny]

I cannot compact all the buttons when using a tag. I have found other place to use onclick, so just follow that.

[lafriks]

DisableDownloadSourceArchives check is now missing and there is duplicate vscode button & menu

[lunny]

DisableDownloadSourceArchives check is now missing and there is duplicate vscode button & menu

fixed.

[silverwind]

I think we should keep this a menu like #19999 did and not add more seldomly used buttons like this vscode button to the always-rendered view. E.g. revert this change, rename button to "More Actions" with new icon and then just add the hide conditions on the individual items that trigger downloads, unconditionally rendering the vscode menu item.

[lafriks]

But there is no point in menu if there is single item in it

[silverwind]

But there is no point in menu if there is single item in it

I'd argue there still is, for sake of consistent user experience where a menu doesn't magically transform into a single-action button.

[lunny]

But there is no point in menu if there is single item in it

I'd argue there still is, for sake of consistent user experience where a menu doesn't magically transform into a single-action button.

I think it's just a habbit problem. The most next action to click the copy button is to paste it in a client commandline or software and then clone the repository. But now, if you are using vscode(about 80% developers used), clicking the second button will finish them more frequently. In future, VSCode button could also become another menus to support gitpod or other offline/online editors which is different from the download archives behaviors.

[silverwind]

I personally do not use VSCode, so this feels like unnecessary preferential treatment of one editor over others. After #19999, will have citation actions as well in that menu and I'm sure there will be more stuff to come. So I still prefer that button to be tucked into that menu.

[lunny]

I personally do not use VSCode, so this feels like unnecessary preferential treatment of one editor over others. After #19999, will have citation actions as well in that menu and I'm sure there will be more stuff to come. So I still prefer that button to be tucked into that menu.

That's my first second version to hide the three menus and left only one menu in the dropdown.

[silverwind]

That's my first version to hide the three menus and left only one menu in the dropdown.

That's what I'd approve, e.g. just move the {{if not $.DisableDownloadSourceArchives}} condition inside the menu so it affects the relevant items only.

[lafriks]

If there is planned adding more menu options than yes, it's no point in making it currently as button and then making it back in menu when other actions are added

[Gusted]

So, why is the VSCode item a new button when the menu is there?

In the same boat as silverwind, I'm not using VSCode and just prefer to have it tucked away in the menu. More items are currently planned to come into that menu, so don't see a good reason to move away from that menu.

[lafriks]

@Gusted it's just one of experimental proposals, if you look over this PR you will see multiple iterations here :)

[lafriks]

But as more items are soon to be added here I agree we should move back to inital commit 9815cf9

[lunny]

I rollbacked to my first version since nobody against that for two days. @lafriks @silverwind @Gusted

[lunny]

make L-G-T-M work