Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable download button #20701

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 7, 2022

Fix #20685

It's wired BaseVars hasn't been used by normal HTML renderering.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 7, 2022
@lunny lunny requested a review from wxiaoguang August 7, 2022 14:34
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@64c371a). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #20701   +/-   ##
=======================================
  Coverage        ?   46.88%           
=======================================
  Files           ?      981           
  Lines           ?   136250           
  Branches        ?        0           
=======================================
  Hits            ?    63881           
  Misses          ?    64521           
  Partials        ?     7848           
Impacted Files Coverage Δ
modules/context/context.go 64.96% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 7, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 7, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 7, 2022
@6543 6543 added this to the 1.18.0 milestone Aug 7, 2022
@lunny lunny added backport/v1.17 backport/done All backports for this PR have been created labels Aug 8, 2022
@6543 6543 merged commit 98190d0 into go-gitea:main Aug 8, 2022
@lunny lunny deleted the lunny/fix_disable_download branch August 8, 2022 13:48
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 9, 2022
* giteaofficial/main:
  Add support for `npm unpublish` (go-gitea#20688)
  Allow multiple files in generic packages (go-gitea#20661)
  Refactor legacy git init (go-gitea#20376)
  Fix typo in source (go-gitea#20723)
  [skip ci] Updated translations via Crowdin
  Add issue filter for Author (go-gitea#20578)
  Fix init mail render logic (go-gitea#20704)
  Frontport changelog v1.17.0 (go-gitea#20712)
  Fix disable download button (go-gitea#20701)
  docs: move search input to navbar (go-gitea#20551)
  Fix SecToTime edge-cases (go-gitea#20610)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@schmurtzm
Copy link

@lunny Seems that the disabling of download button is still broken.

@lunny
Copy link
Member Author

lunny commented Feb 10, 2023

@lunny Seems that the disabling of download button is still broken.

Please fire a new issue with details.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set DISABLE_DOWNLOAD_SOURCE_ARCHIVES to true, but still can download from UI
8 participants