Allow disable part user settings #20549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/enhancement
Merged
noerw
reviewed
Jul 30, 2022
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## main #20549 +/- ##
==========================================
- Coverage 46.94% 46.85% -0.10%
==========================================
Files 978 980 +2
Lines 135489 135838 +349
==========================================
+ Hits 63600 63641 +41
- Misses 64082 64389 +307
- Partials 7807 7808 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
@noerw @jolheiser done. |
KN4CK3R
reviewed
Aug 8, 2022
|
We have just run into a use-case for something similar, but specifically for preventing OAuth'd users from modifying aspects of their profile that are controlled by the provider (password, email address etc). Would an adjustment to this whereby modules could be enabled/disabled depending on the auth type be welcome? |
lunny
force-pushed
the
lunny/disable_user_setting_via_modules
branch
from
3b00cd1
to
6810325
Compare
wolfogre
reviewed
Dec 12, 2022
KN4CK3R
reviewed
Dec 13, 2022
|
@lunny please resolve conflicts |
wxiaoguang
reviewed
Feb 25, 2023
|
More conflicts appeared. |
silverwind
reviewed
Mar 29, 2023
| @@ -1386,6 +1386,16 @@ steps: | |||
|
|
|||
| although Github don't support this form. | |||
|
|
|||
| ## User (`user`) | |||
|
|
|||
| - `USER_SETTING_DISABLED_MODULES`:**** Disabled modules from user settings, could be a copmosite of `password`, `deletion`, `security`, `applications`, `gpg keys`, `organizations` with a comma. | |||
There was a problem hiding this comment.
Suggested change
| - `USER_SETTING_DISABLED_MODULES`:**** Disabled modules from user settings, could be a copmosite of `password`, `deletion`, `security`, `applications`, `gpg keys`, `organizations` with a comma. | |
| - `USER_SETTING_DISABLED_MODULES`: **\<empty\>**: Disabled modules from user settings, could be a copmosite of `password`, `deletion`, `security`, `applications`, `gpg keys`, `organizations` with a comma. |
silverwind
reviewed
Mar 29, 2023
Comment on lines
+1392
to
+1397
| - `password`: User cannot change his password from the website. | ||
| - `deletion`: User cannot remove himself from the website. | ||
| - `security`: User cannot update his security settings from the website. | ||
| - `applications`: User cannot create application himself. | ||
| - `gpg_keys`: User cannot manage gpg keys himself. | ||
| - `organizations`: User cannot manage his organizations himself. |
There was a problem hiding this comment.
Suggested change
| - `password`: User cannot change his password from the website. | |
| - `deletion`: User cannot remove himself from the website. | |
| - `security`: User cannot update his security settings from the website. | |
| - `applications`: User cannot create application himself. | |
| - `gpg_keys`: User cannot manage gpg keys himself. | |
| - `organizations`: User cannot manage his organizations himself. | |
| - `password`: Users cannot change their password from the website. | |
| - `deletion`: Users cannot remove themselves from the website. | |
| - `security`: Users cannot update their security settings from the website. | |
| - `applications`: Users cannot create application themselves. | |
| - `gpg_keys`: Users cannot manage gpg keys themselves. | |
| - `organizations`: Users cannot manage their organizations themselves. |
This was referenced Jun 20, 2023
Closed
lunny
added a commit
that referenced
this pull request
Feb 23, 2024
…29275) Extract from #20549 This PR added a new option on app.ini `[admin]USER_DISABLED_FEATURES` to allow the site administrator to disable users visiting deletion user interface or allow. This options are also potentially allowed to define more features in future PRs. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
|
@lunny Is there a reason that this PR isn't finished? Has it been replaced by something else? I'm happy to contribute if there's more to be done. |
lafriks
pushed a commit
that referenced
this pull request
Mar 2, 2024
lunny
added a commit
that referenced
this pull request
Mar 4, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR split user settings as
passwod,deletion,security,applications,gpg keys,organiztionsmodules. And there is a global configuration to allow/disallow users to visit the modules from UI or requests.