Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xorm.io/xorm to fix a interpreting db column sizes issue on 32bit systems (#20371) #20372

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 14, 2022

Backport #20371

Xorm 1.3.2-0.20220714055524 contains a fix for interpreting db column sizes. Prior to this fix xorm would assume that the size of a column was within the range of an int. This is correct on 64bit machines where int is typical equivalent to int64 however, on 32bit machines int tends to be int32.

Unfortunately the size of a LONGTEXT field is actually max_uint32, thus using strconv.Atoi on these fields will fail and thus #20161 occurs on 32 bit arm. Xorm 1.3.2-0.20220714055524 changes this field to use int64 instead.

Fix #20161

@6543 6543 added issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP backport/done All backports for this PR have been created dependencies labels Jul 14, 2022
@6543 6543 added this to the 1.17.0 milestone Jul 14, 2022
@6543 6543 added the type/bug label Jul 14, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 14, 2022
@6543 6543 mentioned this pull request Jul 14, 2022
@6543 6543 removed the backport/done All backports for this PR have been created label Jul 14, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2022
@6543 6543 merged commit 4c1f4ee into go-gitea:release/v1.17 Jul 14, 2022
@6543 6543 deleted the v1.17_update_xorm branch July 14, 2022 16:42
@6543 6543 changed the title update xorm.io/xorm v1.3.2-0.20220714055524-c3bce556200f (#20371) Update xorm.io/xorm to fix a interpreting db column sizes issue on 32bit systems (#20371) Jul 15, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants