Fix eslint parsing errors, remove eslint-plugin-html #20323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
the
skip-changelog
|
BTW, if |
GiteaBot
added
the
lgtm/need 2
Gusted
approved these changes
Jul 12, 2022
GiteaBot
added
lgtm/need 1
Introduce a separate .eslintrc in the Vue components folder to selectively enable vue-eslint-parser there, so that the rest of the files can use eslint's core parser which can deal with hashbangs. The fact that the eslint-disable comments worked in HTML was a unintended side-effect of the files being parsed via vue-eslint-parser, so I had to disable the parsing of these files in .eslintrc.yaml to make it work.
silverwind
force-pushed
the
fix-eslint-error
branch
from
f9fbbd1
to
e5399c7
Compare
|
Decided to remove @wxiaoguang you probably want to review this. |
silverwind
changed the title
GiteaBot
added
lgtm/done
|
Yes, inline scripts won't get linted anymore, need to be review those extra-carefully. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 15, 2022
* upstream/main: Fix commit status icon when in subdirectory (go-gitea#20285) Fix eslint parsing errors, remove eslint-plugin-html (go-gitea#20323) Include login_name in adminCreateUser response (go-gitea#20283) Add allow_rebase_update, default_delete_branch_after_merge to repository api response (go-gitea#20079) Allow to specify colors for text in markup (go-gitea#20363) [skip ci] Updated translations via Crowdin update xorm.io/xorm v1.3.2-0.20220714055524-c3bce556200f (go-gitea#20371) Add order by for assignee no sort issue (go-gitea#20053) Make sure `repo_dir` is an empty directory or doesn't exist before 'dump-repo' (go-gitea#20205) Fix English mistakes in some Markdown documents (go-gitea#20274) Fix versions check for busybox `sh` (go-gitea#20358)
dineshsalunke
pushed a commit
to dineshsalunke/gitea
that referenced
this pull request
Jul 15, 2022
Introduce a separate .eslintrc in the Vue components folder to selectively enable vue-eslint-parser there, so that the rest of the files can use eslint's core parser which can deal with hashbangs. The fact that the eslint-disable comments worked in HTML was a unintended side-effect of the files being parsed via vue-eslint-parser, so I had to disable the parsing of these files in .eslintrc.yaml to make it work, and finally decided to remove eslint-plugin-html as it causes more issues than it solves.
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Introduce a separate .eslintrc in the Vue components folder to selectively enable vue-eslint-parser there, so that the rest of the files can use eslint's core parser which can deal with hashbangs. The fact that the eslint-disable comments worked in HTML was a unintended side-effect of the files being parsed via vue-eslint-parser, so I had to disable the parsing of these files in .eslintrc.yaml to make it work, and finally decided to remove eslint-plugin-html as it causes more issues than it solves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a separate
.eslintrc.yamlin the Vue components folder to selectively enable vue-eslint-parser there, so that the rest of the files can use eslint's core parser which can deal with hashbangs.The fact that the eslint-disable comments worked in HTML was a unintended side-effect of the files being parsed via vue-eslint-parser, so I had to disable the parsing of these files in .eslintrc.yaml to make it work.
For more context see #20113 and linked issues.