Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated draft PR icon when possible #20303

Merged
merged 3 commits into from
Jul 9, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jul 9, 2022

Before:
image
image

After:
image
image

Gusted added 2 commits July 9, 2022 19:09
- Currently the generic pull-request icon is used for draft PR's. This
patch changes that by using the dedicated icon for this.
- Resolves go-gitea#20296
@Gusted Gusted added this to the 1.18.0 milestone Jul 9, 2022
@Gusted Gusted added the topic/ui-interaction Change the process how users use Gitea instead of the visual appearance label Jul 9, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 9, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2022
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 87c563b into go-gitea:main Jul 9, 2022
@Gusted Gusted deleted the use-dedicated-draft-icon branch July 9, 2022 22:17
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 11, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Vertical align avatar at middle (go-gitea#20302)
  Changed scroll to auto for some UI elements. (go-gitea#20294)
  Add hint to GNUPGHOME environment variable (go-gitea#20134)
  Refactor SSH init code, fix directory creation for TrustedUserCAKeys file (go-gitea#20299)
  [skip ci] Updated translations via Crowdin
  Use dedicated draft PR icon when possible (go-gitea#20303)
  Update goldmark (go-gitea#20300)
  Do not create empty ".ssh" directory when loading config (go-gitea#20289)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
* Use dedicated draft PR icon when possible

- Currently the generic pull-request icon is used for draft PR's. This
patch changes that by using the dedicated icon for this.
- Resolves go-gitea#20296

* Use draft title
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make WIP PRs visually more distinctive
5 participants