Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show OpenID Connect and OAuth on signup page #20242

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Jul 5, 2022

Fix #19809

Fix go-gitea#19809

Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>
@dsseng
Copy link
Contributor Author

dsseng commented Apr 10, 2023

Before:
grafik

After change:
grafik

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2023
@denyskon denyskon added type/enhancement An improvement of existing functionality giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main labels Aug 2, 2023
@GiteaBot GiteaBot removed the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Aug 3, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 7, 2023
@lunny lunny added this to the 1.21.0 milestone Sep 7, 2023
Copy link
Contributor

@jackHay22 jackHay22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@denyskon denyskon added the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Sep 7, 2023
@GiteaBot GiteaBot removed the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Sep 7, 2023
@denyskon
Copy link
Member

denyskon commented Sep 7, 2023

@sh7dm The OAuth2 login page template has changed since your PR. Could you update it to match the new style?

@dsseng
Copy link
Contributor Author

dsseng commented Sep 7, 2023

It might not be done quickly, but will try

@denyskon denyskon added the pr/wip This PR is not ready for review label Sep 10, 2023
@jackHay22
Copy link
Contributor

@sh7dm Anything I can help with this to wrap up this PR?

@dsseng
Copy link
Contributor Author

dsseng commented Sep 11, 2023

I could probably work on it tomorrow. If you'd really like you could possibly edit the necessary templates and then open a PR against ux/oauth-hint-reg on my fork

@jackHay22
Copy link
Contributor

See dsseng#1

@dsseng
Copy link
Contributor Author

dsseng commented Sep 12, 2023

Amazing, thanks @jackHay22!

Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 12, 2023
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Sep 12, 2023
@denyskon denyskon added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed pr/wip This PR is not ready for review labels Sep 13, 2023
@lunny lunny enabled auto-merge (squash) September 13, 2023 05:04
@lunny lunny disabled auto-merge September 13, 2023 05:04
@lunny lunny enabled auto-merge (squash) September 13, 2023 05:04
@lunny lunny merged commit 63b53af into go-gitea:main Sep 13, 2023
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 13, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 13, 2023
* giteaofficial/main:
  fix media description render for orgmode (go-gitea#26895)
  Show OpenID Connect and OAuth on signup page (go-gitea#20242)
  Update status and code index after changing the default branch (go-gitea#27018)
  add sparse url in cargo package guide (go-gitea#26937)
  Add missing 404 response to Swagger (go-gitea#27038)
  Fix object storage path handling (go-gitea#27024)
  [skip ci] Updated translations via Crowdin
  bump rootful to 16gb
  setup go in the nightly release pipeline
  Speed up nightly builds (go-gitea#27045)
  Improve repo/user/org search  (go-gitea#27030)
  Use Actuated.dev runner for nightly builds
  update snap package (go-gitea#27021)
  resolve issue with sort icons on admin/users and admin/runners (go-gitea#24360)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External openid connect (oidc, oauth) providers missing on sign up/register page
7 participants