Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace issues_model.GetReviewersByIssueID() with more generic issues_model.GetReviews() #20119

Closed
wants to merge 13 commits into from
Closed

Replace issues_model.GetReviewersByIssueID() with more generic issues_model.GetReviews() #20119

wants to merge 13 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 24, 2022 •
edited
Loading

Replace issues_model.GetReviewersByIssueID() with more generic issues_model.GetReviews()

@6543 6543 added the type/enhancement An improvement of existing functionality label Jun 24, 2022
@6543 6543 added this to the 1.18.0 milestone Jun 24, 2022
@6543 6543 changed the title Dismiss antecessors reviews if done via web too Dismiss antecessors pull reviews if done via web too Jun 24, 2022
@6543 6543 changed the title Dismiss antecessors pull reviews if done via web too Dismiss antecessors pull reviews if done via web in review dismiss Jun 24, 2022
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 24, 2022
@lunny
Copy link
Member

lunny commented Jun 25, 2022

Looks like this is a bug fix.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 25, 2022
@6543
Copy link
Member Author

6543 commented Jun 25, 2022

well if we like to backport it ... I could not do refactoring ... but If you think it's worth backporting I'll work around it for the backport

@6543 6543 requested a review from lunny June 25, 2022 18:17
@6543
Copy link
Member Author

6543 commented Jun 25, 2022

(test pass localy now ;) -wait for ci ...)

@Fogapod
Copy link
Contributor

Fogapod commented Jun 25, 2022

is this supposed to resolve #16536 ?

@6543
Copy link
Member Author

6543 commented Jul 1, 2022

is this supposed to resolve #16536 ?

no

@6543 6543 changed the title Dismiss antecessors pull reviews if done via web in review dismiss [WIP] refactor around dismiss antecessors pull reviews .... Jul 1, 2022
@6543 6543 added the pr/wip This PR is not ready for review label Jul 1, 2022
@6543
Copy link
Member Author

6543 commented Jul 1, 2022

-> #20197

@6543 6543 changed the title [WIP] refactor around dismiss antecessors pull reviews .... Replace issues_model.GetReviewersByIssueID() with more generic issues_model.GetReviews() Jul 19, 2022
@6543 6543 removed the type/enhancement An improvement of existing functionality label Jul 19, 2022
@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022
@lunny lunny modified the milestones: 1.19.0, 1.20.0 Jan 31, 2023
@wxiaoguang
Copy link
Contributor

Stale and conflicted, what's the purpose of this PR and what's the status? 🙏

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label May 8, 2023
@wxiaoguang
Copy link
Contributor

Kindly second ping ~~

@wxiaoguang
Copy link
Contributor

Maybe this PR could be closed? Feel free to complete the description and reopen.

@wxiaoguang wxiaoguang closed this May 21, 2023
@GiteaBot GiteaBot removed this from the 1.20.0 milestone May 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @Fogapod @wxiaoguang @GiteaBot