Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 64-bit atomic operations on 32-bit machines #19531

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix 64-bit atomic operations on 32-bit machines #19531

merged 2 commits into from
Apr 27, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Apr 27, 2022

Gusted added 2 commits April 27, 2022 16:16
Fix 64-bit atomic operations on 32-bit machines
b8e8a40 
- Doing 64-bit atomic operations on 32-bit machines is a bit tricky by
golang, as they can only be done under certain set of
conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
- This PR fixes such case whereby the conditions weren't met, it moves
the int64 to the first field of the struct, which will 64-bit operations
happening on this property on 32-bit machines.
- Resolves go-gitea#19518
Merge branch 'main' into fix-atomic-operation
c6bd3f5
Gusted pushed a commit to Gusted/gitea that referenced this pull request Apr 27, 2022
Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531)
c99ea37 
- Backport go-gitea#19531
  - Doing 64-bit atomic operations on 32-bit machines is a bit tricky by golang, as they can only be done under certain set of conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
  - This PR fixes such case whereby the conditions weren't met, it moves the int64 to the first field of the struct, which will 64-bit operations happening on this property on 32-bit machines.
  - Resolves go-gitea#19518
@Gusted Gusted mentioned this pull request Apr 27, 2022
Merged
@Gusted Gusted added this to the 1.17.0 milestone Apr 27, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 27, 2022
@Gusted Gusted added the backport/done All backports for this PR have been created label Apr 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2022
@jolheiser jolheiser merged commit b538359 into go-gitea:main Apr 27, 2022
jolheiser pushed a commit that referenced this pull request Apr 27, 2022
Fix 64-bit atomic operations on 32-bit machines (#19531) (#19532)
1465e0c 
- Backport #19531
  - Doing 64-bit atomic operations on 32-bit machines is a bit tricky by golang, as they can only be done under certain set of conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
  - This PR fixes such case whereby the conditions weren't met, it moves the int64 to the first field of the struct, which will 64-bit operations happening on this property on 32-bit machines.
  - Resolves #19518
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 28, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
509d619 
* giteaofficial/main: (21 commits)
  Prevent intermittent race in attribute reader close (go-gitea#19537)
  Make repository file list useable on mobile (go-gitea#19515)
  Update image URL for Discord webhook (go-gitea#19536)
  [skip ci] Updated translations via Crowdin
  Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531)
  Fix `upgrade.sh` script error with `su -c` (go-gitea#19483)
  When view _Siderbar or _Footer, just display once (go-gitea#19501)
  Fix migrate release from github (go-gitea#19510)
  Prevent dangling archiver goroutine (go-gitea#19516)
  Don't let repo clone URL overflow (go-gitea#19517)
  Add commit status popup to issuelist (go-gitea#19375)
  Disable unnecessary GitHooks elements (go-gitea#18485)
  Disable unnecessary GitHooks elements
  Improve dashboard's repo list performance (go-gitea#18963)
  By default force vertical tabs on mobile (go-gitea#19486)
  Refactor readme file renderer (go-gitea#19502)
  Allow package dump skipping (go-gitea#19506)
  Unset git author/committer variables when running integration tests (go-gitea#19512)
  Allow commit status popup on /pulls page (go-gitea#19507)
  Use router param for filepath in GetRawFile (go-gitea#19499)
  ...
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Apr 28, 2022
@fnetX
Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531) (go-…
dc03d44 
…gitea#19532)

- Backport go-gitea#19531
  - Doing 64-bit atomic operations on 32-bit machines is a bit tricky by golang, as they can only be done under certain set of conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
  - This PR fixes such case whereby the conditions weren't met, it moves the int64 to the first field of the struct, which will 64-bit operations happening on this property on 32-bit machines.
  - Resolves go-gitea#19518
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@AbdulrhmnGhanem
Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531)
fec2184 
- Doing 64-bit atomic operations on 32-bit machines is a bit tricky by
golang, as they can only be done under certain set of
conditions(https://pkg.go.dev/sync/atomic#pkg-note-BUG).
- This PR fixes such case whereby the conditions weren't met, it moves
the int64 to the first field of the struct, which will 64-bit operations
happening on this property on 32-bit machines.
- Resolves go-gitea#19518
@sebastianertz sebastianertz mentioned this pull request Dec 30, 2022
Closed
@Gusted Gusted deleted the fix-atomic-operation branch December 30, 2022 11:28
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Gitea crashes with "unaligned 64-bit atomic operation"
6 participants
@Gusted @wxiaoguang @6543 @delvh @GiteaBot @jolheiser