Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node12 is EOL #19451

Merged
merged 2 commits into from
Apr 21, 2022
Merged

node12 is EOL #19451

merged 2 commits into from
Apr 21, 2022

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 21, 2022
@techknowlogick techknowlogick added this to the 1.17.0 milestone Apr 21, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2022
@techknowlogick techknowlogick merged commit 225044e into go-gitea:main Apr 21, 2022
@techknowlogick techknowlogick deleted the deprecate-node12 branch April 21, 2022 01:17
@silverwind
Copy link
Member

silverwind commented Apr 21, 2022

I would revert because there is no necessity to require v14 and some OS are still shipping very old Node versions. For example, Ubuntu 22.04 ships with the v12 branch, they probably won't update to new major versions during the lifetime of that version. Also, the update missed updating version in at least in README, Makefile.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 21, 2022

IMO this PR is correct (or, at least, not wrong)

Also, the update missed updating version in at least in README, Makefile.

It doesn't miss anything, instead, it just makes everything correct (and up-to-dated).

For example, in README, it already say that Gitea requires "Node.js LTS" and the link points to Node.js 16 LTS.

For Makefile, it just checks package.json

And for package.json, it already declared "node": ">= 14"

I don't know what's the necessary to keep using an outdated nodejs shipped with OS. For example, Debian 11 (stable) only has Golang 1.15, do you want to make the code can be compiled with Go 1.15?

@silverwind
Copy link
Member

silverwind commented Apr 21, 2022

For example, in README, it already say that Gitea requires "Node.js LTS" and the link points to Node.js 16 LTS.
For Makefile, it just checks package.json

Right, I forgot we had it that way already.

I don't know what's the necessary to keep using an outdated nodejs. For example, Debian 11 (stable) only has Golang 1.15, do you want to make the code can be compiled with Go 1.15?

My point is we should declare our minimum supported version and that remains v12.17 or greater. There's no strict need for v14 now and v12 will still see a lot of usage even if unsupported because it comes in Ubuntu/Debian base repos. IIRC, the Ubuntu/Debian maintainers will still backport critical fixes into those "forked" versions so the remain "supported" in a sense, just not by Node.js team.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 21, 2022
* giteaofficial/main:
  Fix logging of Transfer API (go-gitea#19456)
  RepoAssignment ensure to close before overwrite (go-gitea#19449)
  node12 is EOL (go-gitea#19451)
  Add Changelog v1.16.6 (go-gitea#19339) (go-gitea#19450)
  Fix DELETE request for non-existent public key (go-gitea#19443)
  [skip ci] Updated translations via Crowdin
  Don't panic on `ErrEmailInvalid` (go-gitea#19441)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* node12 is EOL

* fix lockfile
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants