Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip frontend ROOT_URL check on installation page, remove unnecessary global var #19291

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Skip frontend ROOT_URL check on installation page, remove unnecessary global var #19291

merged 2 commits into from
Apr 1, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 1, 2022 •
edited
Loading

  1. It's not necessary to run checkAppUrl on installation page, because at that time, the ROOT_URL is not determined yet
  2. Move global var supportedDbTypeNames into install.Init as a local var

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 1, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Apr 1, 2022
@wxiaoguang wxiaoguang mentioned this pull request Apr 1, 2022
Closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2022
@wxiaoguang wxiaoguang merged commit 5b74660 into go-gitea:main Apr 1, 2022
@wxiaoguang wxiaoguang deleted the fix-install branch April 1, 2022 08:00
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a680650 
* giteaofficial/main:
  Remove legacy unmaintained packages, refactor to support change default locale (go-gitea#19308)
  [skip ci] Updated translations via Crowdin
  Prevent intermittent NPE in queue tests (go-gitea#19301)
  Upgrade xorm/builder from v0.3.9 to v0.3.10 (go-gitea#19296)
  An attempt to sync a non-mirror repo must give 400 (Bad Request) (go-gitea#19300)
  Remove legacy `unknwon/com` package (go-gitea#19298)
  Improve package registry docs (go-gitea#19273)
  A pull-mirror repo should be marked as such on creation (go-gitea#19295)
  Refactor legacy `unknwon/com` package, improve golangci lint (go-gitea#19284)
  Skip frontend ROOT_URL check on installation page, remove unnecessary global var (go-gitea#19291)
@wxiaoguang wxiaoguang mentioned this pull request Apr 8, 2022
Merged
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 8, 2022 •
edited
Loading

FYI:

Using HTMLURL in templates is the root case that Gitea can only serve web under ROOT_URL. That's why we have to force users to set ROOT_URL correctly, and that's that PR came.

If all URLs in template can be refactored to use Relative URL correctly, then we do not need to force users set ROOT_URL correctly again and again.

Sorry, wrong place, I should comment on

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @6543 @Gusted @GiteaBot