Performance improvement for add team user when org has more than 1000 repositories #19227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
performance/speed
6543
approved these changes
Mar 29, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
Mar 31, 2022
GiteaBot
added
lgtm/done
|
@lunny I think we can merge this ... so we have at least a better addUserToTeam.... but long term the crafted builder.Conditions should be returned by a func that can be used everywhere .... tldr: we should focus on making more builder constrains and use them instead of filter in for loops at go code ... |
lunny
force-pushed
the
lunny/performance_add_team_user
branch
from
f5b96d2
to
2cc688f
Compare
lunny
removed
pr/wip
|
make L-G-T-M work. |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 1, 2022
… repositories (go-gitea#19227) * performance improvement for add team user when org has more than 1000 repositories * Fix bug * Fix bug
lunny
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 1, 2022
* giteaoffical/main: Fix broken of team create (go-gitea#19288) Remove `git.Command.Run` and `git.Command.RunInDir*` (go-gitea#19280) Performance improvement for add team user when org has more than 1000 repositories (go-gitea#19227) [skip ci] Updated translations via Crowdin Update JS dependencies (go-gitea#19281) Fix container download counter (go-gitea#19287) go.mod: update kevinburke/ssh_config to v1.2.0 (go-gitea#19286) Fix global packages enabled avaiable (go-gitea#19276) Add Goroutine stack inspector to admin/monitor (go-gitea#19207) Move checks for pulls before merge into own function (go-gitea#19271) Restore user autoregistration with email addresses (go-gitea#19261) Improve sync performance for pull-mirrors (go-gitea#19125) Refactor `git.Command.Run*`, introduce `RunWithContextString` and `RunWithContextBytes` (go-gitea#19266) Move reaction to models/issues/ (go-gitea#19264)
lafriks
pushed a commit
that referenced
this pull request
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19216